Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pentax k1 #1201

Closed
wants to merge 15 commits into from
Closed

Pentax k1 #1201

wants to merge 15 commits into from

Conversation

@mazhe
Copy link
Contributor

@mazhe mazhe commented May 9, 2016

Hello, I'd like to submit for review/inclusion some patches related to work I did to add support for the Pentax K-1 camera.

Mostly, it consists of :

  • adding a color matrix (taken from DNG raw file)
  • updates in the noise tools (using sh instead of bash, allowing to use different exif tags to get iso levels > 65536)

Thanks in advance,

@mazhe mazhe closed this Jul 19, 2016
@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Aug 9, 2016

@mazhe i assume this still is an issue. Let's try this again...

I guess this is related to https://redmine.darktable.org/issues/11022

Was the sample sent to rawspamples.ch too?

@LebedevRI LebedevRI reopened this Aug 9, 2016
@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Aug 9, 2016

In fact, I closed the request (silently) to take time to understand a few issues (I was getting black images from PEF format, DNG was fine).

I'll send two samples to rawsamples.ch indeed, that could be helpful.

I still have noise profiles ready, that I did not found to be faulty in my everyday usage, but I did not formally test every iso setting yet...

@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Aug 11, 2016

Ok, I have cleared up my issue with black PEF : it seems to be a regression in rawspeed when build with clang 3.8 and -O3, not something coming from this patchset. I'll investigate this later.

Samples were sent to rawsamples.ch (both PEF and DNG).

I still have to extract whitebalance presets and check the noiseprofiles.

@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Aug 11, 2016

Ok, I have cleared up my issue with black PEF

What exactly was the issue?
There is some kind of race condition when entering darkroom when image is not loaded yet, so darkroom opens, but the image is displayed black.
Re-entering darkroom fixes that.

@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Aug 11, 2016

The only questionable thing here is crop, so please take a fully clipped (!) image - fully open aperture, iso100, 30 sec exposure, and upload it somewhere.

@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Aug 11, 2016

Thanks for the info about the race condition, I'll check that a bit later.

I'll do the sample picture when I'm back home (the crop was obtained from information in the DNG if I remember, and set because there was garbage lines at the begining of the PEF pictures).

@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Aug 11, 2016

Here are the samples, PEF & DNG:

@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Aug 11, 2016

Can you upload that to some sane location, like dropbox?
That one is blocked for me, and i do not understand how to download from
there.

On Thu, Aug 11, 2016 at 7:11 PM, Matthieu Volat notifications@github.com
wrote:

Here are the samples, PEF & DNG:


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1201 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFaGKE7BBh_NJb89phFh8H_GyTQCzDWks5qe0mtgaJpZM4IaV0a
.

@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Aug 12, 2016

Thanks, merged manually.
Please do send a sample to rawsamples.ch

@LebedevRI LebedevRI closed this Aug 12, 2016
@LebedevRI LebedevRI added this to the 2.1 milestone Oct 16, 2016
@LebedevRI LebedevRI added this to the 2.1 milestone Oct 16, 2016
@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Dec 9, 2017

@mazhe Hi!
Could you please help us with raw samples for this camera for https://raw.pixls.us/?

There are total of 6 samples. The camera needs to be stable (tripod), and the scene needs to be as static as possible (so some daylight nature landscape would be best), and all the samples must have the same content/scene:

  • 35mm Full-Frame:
    • pixelshift OFF
      • PEF
      • DNG
    • pixelshift ON
      (i.e. one with motion correction and one without)
      • PEF (motion correction either ON or OFF)
      • DNG (motion correction either OFF or ON)
  • APS-C crop, pixelshift OFF
    • PEF
    • DNG
@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Dec 9, 2017

Yes, I can and will do ASAP (tried from my appartment, but view is a bit trouble and light is changing too much due to cloud moving in and out).

I'll also put some 1:1 crop raw for good measure.

(I'm also working on providing better noise profiles, but high ISOs are really hard to calibrate... I've been working on smoothing the data with interpolation with good results in my eye...)

@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Jan 13, 2018

So far we've failed to find any 645D/645Z owner willing to contribute the samples.
Perhaps someone with K1 could still help.

@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Jan 29, 2018

Sorry, I was a bit overwhelmed by events last weeks (moving to another town, new job), I'll get back on this ASAP

@mazhe
Copy link
Contributor Author

@mazhe mazhe commented Mar 23, 2018

Ok, sorry for the delay, but at least a bright and nice day. I took PEF/DNG with all FF/APSC and PS variations.

There are already entries for the K1, but not all variations, should I fill or overwrite all images?

@LebedevRI
Copy link
Member

@LebedevRI LebedevRI commented Mar 23, 2018

(In the mean time, the 645[zd] samples were received)

There are already entries for the K1

Just upload all of those your shot.

@LebedevRI LebedevRI added this to Untriaged in New Camera Support via automation Jun 30, 2019
@LebedevRI LebedevRI moved this from Untriaged to Resolved in New Camera Support Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
New Camera Support
  
Resolved
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.