po/rework workflow & module groups

[TurboGit]

1. Rework the workflow preference to be simpler.

   The new values are now:

   • scene-refrerred (filmic)
   • scene-referred (sigmoid)
   • display-referred (legacy)
   • none

   The chromatic-adaptation is implied by the workflow setting (removing
   one preference). And is "modern" for all scene-referred workflow.

2. Rework the module groups to be simpler.

   • Remove the "default" group.
   • Add either Sigmoid or FilmicRGB module based on current workflow
   • Use Sigmoid instead of FilmicRGB for the beginner workflow.

Fixes #12917.

[Nilvus]

Good move but remains one thing not good with your PR. If you don't set any workflow on preferences, then on modulegroups, you only have scene-referred workflow with sigmoid and no more filmic. Some users (like me) will still prefer filmic to sigmoid and if no workflow set on preferences, modulegroups should give both choices: with sigmoid or filmic.

[TurboGit]

Indeed, so if workflow is set to None we probably want both Sigmoid & Filmic to be in the scene-referred module group.

[TurboGit]

@Nilvus : Should be fixed now.

[Nilvus]

Good. Thanks. I'm just wondering if it wouldn't be better to have 2 workflow on modulegroups for scene-referred. One with sigmoid and other with filmic, instead of one with both modules. filmic and sigmoid do not have to be used together.

[jandren]

I had liked to see the selection of display transform and the chosen module order to be decoupled if possible!

So in preferences:
Module order

• Display Referred
• Scene Referred

Auto apply display transform

• Base Curve
• Base Curve "camera" (the current auto apply check box)
• Filmic
• Sigmoid

How do you feel about that?

[TurboGit]

Not sure it makes lot of sense to have Display Referred & Filmic (or Sigmoid). This was discussed here btw, #12917.

So it feels better to me to have safe preferences and the choice None for people wanting to create their own workflow using auto-applied presets.

[Nilvus]

Ok

[AlicVB]

first, very quick test :

• at startup , when opening preferences, I have :
  
  See the "empty" combobox... I think it's due to the fact that my previous setting is no longer in the list

Also, I wonder if the "auto-apply per camera basecurve presets" couldn't be squashed inside our new preference...

Another point : I think we should follow the preference setting also for the beginner workflow.

I'll test again and review the code later ;)

[TurboGit]

See the "empty" combobox... I think it's due to the fact that my previous setting is no longer in the list

This is a separate bug already fixed on master (and 4.2 branch) 82963e7. Let me rebase this branch.

[TurboGit]

Also, I wonder if the "auto-apply per camera basecurve presets" couldn't be squashed inside our new preference...

You mean having two display referred entries as workflows:

• display referred
• display referred (camera base curve)

(no more legacy in the name for keep the label short)

I have no strong opinion, not sure what is better/simpler/clearer there.

[AlicVB]

You mean having two display referred entries as workflows:

either this or just one workflow for display referred and we choose the most directly usable one (I'm not sure as it was a long time since I've switch to scene referred, but iirc camera base curve was quite ok for a first starting point)

That would remove one pref item, not needed in most cases as scene referred is the default nowdays... In fact we should even only show this pref for display referred workflows (but that would means lot of code change in preference.c for such a corner case)

[TurboGit]

either this or just one workflow for display referred and we choose the most directly usable one (I'm not sure as it was a long time since I've switch to scene referred, but iirc camera base curve was quite ok for a first starting point)

Sadly I'm not sure that's true for all camera. But I have left the display referred workflow to assess the current status.

[TurboGit]

Merged, we can adjust the camera specific curve later if needed.