Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po/style multi name #13391

Closed
wants to merge 5 commits into from
Closed

Conversation

TurboGit
Copy link
Member

Properly support hand edited multi-name for styles.

@TurboGit TurboGit added this to the 4.4 milestone Jan 20, 2023
@TurboGit TurboGit added feature: enhancement current features to improve priority: high core features are broken and not usable at all, software crashes scope: UI user interface and interactions scope: codebase making darktable source code easier to manage release notes: pending labels Jan 20, 2023
@TurboGit TurboGit marked this pull request as draft January 20, 2023 17:21
@TurboGit TurboGit force-pushed the po/style-multi-name branch from 6608378 to f68883a Compare January 23, 2023 18:00
@TurboGit TurboGit marked this pull request as ready for review January 23, 2023 18:01
Ensure that the multi-name is kept if edited explicitly.
The name meaningful when copying/pasting history.
Make sure that the multi_name is ignored for first-instance
when copy/paste is done to avoid creating multiple instances.
We actually ignore except if the name has been hand edited.

Fixes darktable-org#13415.
@TurboGit TurboGit force-pushed the po/style-multi-name branch from f68883a to be1687c Compare January 24, 2023 16:16
@TurboGit TurboGit closed this Jan 24, 2023
@TurboGit
Copy link
Member Author

Merged maualy with conflict resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: enhancement current features to improve priority: high core features are broken and not usable at all, software crashes scope: codebase making darktable source code easier to manage scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant