noise profile: read Hi/Lo iso values, refs #11580, fixes #11842 #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arktable-org#11842 This fixes "./gen-profile: 1: eval: Bad substitution" error during noise profile calculation with same nikon images. Tested with images from darktable-org#11580, fix is copied from darktable-org#11842. exiv2 reports {{{ $ exiv2 -g "Exif.NikonIi.ISO" -Pt DSC_1083.NEF 79 Lo 0.3 79 Lo 0.3 }}} which can not be parsed correct with current script. 79 seems to be the correct iso value as it is reported from exiv2 without key argument. {{{ $ exiv2 DSC_1083.NEF | grep ISO ISO speed : 79 }}}
LebedevRI
reviewed
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "./gen-profile: 1: eval: Bad substitution" error
during noise profile calculation with same nikon images.
Tested with images from #11580, fix is copied from #11842.
exiv2 reports
{{{
$ exiv2 -g "Exif.NikonIi.ISO" -Pt DSC_1083.NEF
79
Lo 0.3
79
Lo 0.3
}}}
which can not be parsed correct with current script.
79 seems to be the correct iso value as it is reported from exiv2
without key argument.
{{{
$ exiv2 DSC_1083.NEF | grep ISO
ISO speed : 79
}}}