New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkroom UI refactor #1745

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@aurelienpierre
Contributor

aurelienpierre commented Oct 10, 2018

This is what is currently discussed on the dev mailing list.

This PR aims at drawing an unidirectional path between the modules, to show in which order the user has to set them to get better results while avoiding editing in circles (going back on previously set modules because we changed their input). This order is mostly the pixelpipe one.

basic modules tab:
every technical module related to dynamic range restoration (+ crop and flip) that needs to be set before the input color correction. Leaving this tab, the image should look dull and unclipped.

correction modules tab:
every technical module related to image reconstruction (denoising, highlights recovery). Leaving this tab, the image should look clean and dull.

tone modules tab:
every artistic module related to (local and global) contrast and lightness. Drawback: several modules handle colors as well. Setting the tones will affect the saturation, especially in Lab, so it's better to do it before the colors.

color modules tab:
every artistic module related to colors. Not much change here except for the color mapping module here.

effects module tab:
every filter used to enhance the picture.

Benefits:

  • if you don't know where to begin with 8 different modules that fix the lightness and 3 different modules for tonemapping, now you just have to follow the UI order.
  • fixing the dynamic range before the color correction is critical to retain color accuracy. It is not the place in the exposure module to try setting the contrast.
  • if you follow this order, you shouldn't have to ever come back on a previously set module.
  • it makes the technical part of the editing (reconstruction and recovering) fully separate from the creative part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment