Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow middle-click to be used to open the presets. #1887

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@TurboGit
Copy link
Member

commented Dec 9, 2018

This allow middle-click to open and middle-click to select the
preset to apply on the new instance, so avoiding the left-click to middle
click finger move.

For #12453.

@TurboGit TurboGit added the enhancement label Dec 9, 2018

@TurboGit TurboGit added this to the 2.6.1 milestone Dec 9, 2018

@TurboGit TurboGit self-assigned this Dec 9, 2018

@moy

This comment has been minimized.

Copy link
Contributor

commented Dec 9, 2018

Looks good to me. Note that it doesn't apply to lightroom modules (like "export selected"). It doesn't matter much because these modules don't have the "multiple instances" thing like darkroom, but since the button has the same shape it may make sense to have exactly the same behavior hence allow middle-click.

@TurboGit

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

Good point! I'll add that, consistency is a very strong argument to me.

Allow middle-click to be used to open the presets.
This allow middle-click to open and middle-click to select the
preset to apply on the new instance, so avoiding the left-click to middle
click finger move.

For #12453.

@TurboGit TurboGit force-pushed the preset-middle-click branch from b48c878 to b97c5f0 Dec 9, 2018

@TurboGit

This comment has been minimized.

Copy link
Member Author

commented Dec 26, 2018

manually merged.

@TurboGit TurboGit closed this Dec 26, 2018

@TurboGit TurboGit deleted the preset-middle-click branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.