New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tone equalizer : prototype [WIP] #1904

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@aurelienpierre
Copy link
Contributor

aurelienpierre commented Dec 16, 2018

introduce a new "tone equalizer " module, intended to allow selective exposure adjustements in linear RGB (supposed to be color-safe). This is very similar to Lightroom, with blacks/shadows/midtones/highlights/whites cursors.

The luminance channels are blended with gaussian masks and the modifications are applied on a gaussian pyramid to preserve the local contrast (luminance modified in low frequency layers).

For now, nothing is optimized (naive C implementation) and the module is expected to be slow. This is just a proof of concept. I will make it faster once the core algorithm is validated.

@aurelienpierre aurelienpierre force-pushed the aurelienpierre:toneequalizer branch 3 times, most recently from ee2c591 to 9dd8541 Dec 16, 2018

@TurboGit TurboGit self-requested a review Dec 28, 2018

@TurboGit TurboGit self-assigned this Dec 28, 2018

@TurboGit TurboGit added this to the 2.8 milestone Dec 28, 2018

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Dec 28, 2018

Sounds very promising!

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 2, 2019

Just tested, quite nice indeed. The transitions are "smoothed" and so the tonality are pleasant. Nice work.

@aurelienpierre

This comment has been minimized.

Copy link
Contributor

aurelienpierre commented Jan 2, 2019

Thanks ! I have yet to squeeze in there either a laplacian pyramid or a wavelet decomposition to affect only the low frequencies, because I find it flattens a bit too much the local contrast.

aurelienpierre added some commits Dec 16, 2018

tone equalizer : prototype [WIP]
introduce a new "tone equalizer " module, intended to allow selective exposure adjustements in linear RGB (supposed to be color-safe).

This is very similar to Lightroom, with blacks/shadows/midtones/highlights/whites cursors.

The luminance channels are blended with gaussian masks and the modifications are applied on a gaussian pyramid to preserve the local contrast (luminance modified in low frequency layers).

For now, nothing is optimized (naive C implementation). This is just a proof of concept.

@aurelienpierre aurelienpierre force-pushed the aurelienpierre:toneequalizer branch from 5e92b0a to 8e0f4ef Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment