New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey/Exposé lighttable layout. #1968

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@oexler
Copy link
Contributor

oexler commented Jan 3, 2019

This is the first draft of a new lighttable layout to show multiple selected images like e.g. survey mode in lightroom.
Currently it has a few limitations. For example the aspect ratio is not calculated for all images (sort by ratio only calculates on demand)
With ctrl+click you can unselect images.
For the calculation I mainly used code from an old task manager skippy, but adapted for non-rectangular windows. There probably is a better way.

What do you think?

@oexler

This comment has been minimized.

Copy link
Contributor

oexler commented Jan 3, 2019

bildschirmfoto 2019-01-03 um 18 20 40

@TurboGit TurboGit self-requested a review Jan 3, 2019

@TurboGit TurboGit self-assigned this Jan 3, 2019

@TurboGit TurboGit added the enhancement label Jan 3, 2019

@TurboGit TurboGit added this to the 2.8 milestone Jan 3, 2019

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 3, 2019

Like the idea, but...
/home/obry/dev/builds/darktable/build/src/src/views/lighttable.c: In function ‘expose_expose’: /home/obry/dev/builds/darktable/build/src/src/views/lighttable.c:1455:3: error: label ‘failure’ defined but not used [-Werror=unused-label] failure: ^~~~~~~

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 3, 2019

Fixing the failure above I was able to look at this.

My first impression is that we want the filmstrip activated only in exposé mode and not have it in other modes.

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 3, 2019

Apart from that, it is a very nice tool to select pictures. I've been using in Lr long time ago. You want of course to be able to rate and reject pictures in this mode and ensure rejected images are automatically removed from the exposé view.

Please keep up the nice work on this! Thanks.

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 3, 2019

I would suggest also that when in grouped mode, selecting the group leader would display all pictures in the group.

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 3, 2019

My first impression is that we want the filmstrip activated only in exposé mode and not have it in other modes.

I see that this is what you have coded, but exit dt in file navigator mode. Restart dt and the filmstrip will be displayed.

@MRIG

This comment has been minimized.

Copy link
Member

MRIG commented Jan 3, 2019

@aurelienpierre

This comment has been minimized.

Copy link
Contributor

aurelienpierre commented Jan 3, 2019

I like that !

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 12, 2019

There is conflicts due to the lighttable rework to speed it up. Do not hesitate to rebase on master and ask if you have questions. I'm eager to see this in action :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment