New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageio_tiff: support for 8/16bit tiff with CIELAB/ICCLAB photometric #1996

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
4 participants
@upegelow
Copy link
Member

upegelow commented Jan 12, 2019

TIFF files with CIELAB or ICCLAB format get converted to sRGB on input.

@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 12, 2019

Sounds good! Do you think this can/should go in 2.6.1?

@parafin

This comment has been minimized.

Copy link
Member

parafin commented Jan 12, 2019

Shouldn't it be kept in LAB and just set LAB colorspace in colorin iop? Is conversion LAB->sRGB->LAB lossless?

@upegelow

This comment has been minimized.

Copy link
Member Author

upegelow commented Jan 12, 2019

Shouldn't it be kept in LAB and just set LAB colorspace in colorin iop? Is conversion LAB->sRGB->LAB lossless?

There are a lot of modules before colorin that implicitely assume RGB input. One of it is retouch and the wish to use this module for certain scanner images has been the starting point for the PR.

@upegelow

This comment has been minimized.

Copy link
Member Author

upegelow commented Jan 12, 2019

Sounds good! Do you think this can/should go in 2.6.1?

Let's wait a bit. I am interested to see if this really works well. Also the decision to convert to sRGB might be debatable with e.g. AdobeRGB being an alternative.

@aurelienpierre

This comment has been minimized.

Copy link
Contributor

aurelienpierre commented Jan 14, 2019

Sounds good! Do you think this can/should go in 2.6.1?

Let's wait a bit. I am interested to see if this really works well. Also the decision to convert to sRGB might be debatable with e.g. AdobeRGB being an alternative.

As a working space, linear RGB spaces like REC2020 are most secure due to the proximity with pure spectral primaries. If it's an achival space, ACES P0 is the best, Prophoto RGB works too.

@upegelow upegelow merged commit c78292e into darktable-org:master Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TurboGit

This comment has been minimized.

Copy link
Member

TurboGit commented Jan 16, 2019

Ulrich, so what about 2.6?

@upegelow

This comment has been minimized.

Copy link
Member Author

upegelow commented Jan 16, 2019

Ulrich, so what about 2.6?

It's fine to cherry-pick into 2.6 (see discussion in darktable-users).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment