Fix object mask cursor indicator leaking under overlay windows#21099
Merged
TurboGit merged 1 commit intoMay 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're in the object mask creation mode and you open preferences (or any other window) over the darkroom without leaving the mask tool, the mask's "+" cursor indicator keeps tracking the cursor underneath the overlay – you can see it moving on the darkroom behind the prefs window as you move the mouse over the prefs widgets.
Root cause: the mask tool's post-expose handler calls
gdk_window_get_device_position()every redraw to figure out where to draw the indicator. That function returns the pointer's coordinates relative to the darkroom window regardless of which window the cursor is actually over, so as long as the coordinates land inside the canvas bounds, the indicator gets drawn there – even when the cursor is visually somewhere else.Fix: also ask
gdk_device_get_window_at_position()which window the pointer is actually over, and skip the indicator if it's not the darkroom canvas.