-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export metadata - replace fixed tag list by exiv2 list #3951
Conversation
|
Retrieving more metadata from exiv2 brings some data types which are not covered today like Rational or SRational types. Some more work must be done at least to prevent to fulfill a tag with not coherent values. |
89fa843 to
bb0e398
Compare
|
adding metadata exiv2 type information |
|
Some variables like $(EXIF_APERTURE) are not suitable to set up the metadata tag Exif.Photo.ApertureValue which is a RATIONAL (two longs) as commented in that thread https://discuss.pixls.us/t/darktable-3-0-exif-on-export/15486. I've worked on the exiv2 metadata types (which are now visible in the metadata tag dictionary) but it seems difficult to convert properly the variables to such metadata. Except other argument I don't plan any work on this. However in the same thread it appears useful to be able to remove all exif tags except some. Here comes the last commit which adds the possibility to enter '=' in the formula. This says that, despite exif tags are disabled, such a tag has to be exported. EDIT: if exif tags are not disabled "=" does nothing. |
|
3.2... end of the year. :( |
|
@phweyland : Don't be sad, it's an open project we can discuss everything. I put 3.2 because I feel this could wait but we can reconsider. Maybe for 3.0.1 or 3.0.2 ? |
|
There are 2 points in that PR. |
|
Manually merged on master and 3.0.1 branch. |


Replaced the hard coded metadata list by an exiv2 standard one.