Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export metadata - replace fixed tag list by exiv2 list #3951

Closed
wants to merge 2 commits into from

Conversation

phweyland
Copy link
Contributor

Replaced the hard coded metadata list by an exiv2 standard one.

@phweyland phweyland changed the title export metdata - replace fixed tag list by exiv2 list export metadata - replace fixed tag list by exiv2 list Dec 30, 2019
@phweyland phweyland changed the title export metadata - replace fixed tag list by exiv2 list WIP - export metadata - replace fixed tag list by exiv2 list Dec 30, 2019
@phweyland
Copy link
Contributor Author

phweyland commented Dec 30, 2019

Retrieving more metadata from exiv2 brings some data types which are not covered today like Rational or SRational types. Some more work must be done at least to prevent to fulfill a tag with not coherent values.

@phweyland
Copy link
Contributor Author

adding metadata exiv2 type information

@phweyland phweyland changed the title WIP - export metadata - replace fixed tag list by exiv2 list export metadata - replace fixed tag list by exiv2 list Jan 3, 2020
@phweyland
Copy link
Contributor Author

phweyland commented Jan 3, 2020

Some variables like $(EXIF_APERTURE) are not suitable to set up the metadata tag Exif.Photo.ApertureValue which is a RATIONAL (two longs) as commented in that thread https://discuss.pixls.us/t/darktable-3-0-exif-on-export/15486.

I've worked on the exiv2 metadata types (which are now visible in the metadata tag dictionary) but it seems difficult to convert properly the variables to such metadata. Except other argument I don't plan any work on this.

However in the same thread it appears useful to be able to remove all exif tags except some. Here comes the last commit which adds the possibility to enter '=' in the formula. This says that, despite exif tags are disabled, such a tag has to be exported. EDIT: if exif tags are not disabled "=" does nothing.

image

The metadata tag dictionary looks now like that:
image

@TurboGit TurboGit self-requested a review January 4, 2020 22:00
@TurboGit TurboGit self-assigned this Jan 4, 2020
@TurboGit TurboGit added the feature: enhancement current features to improve label Jan 4, 2020
@TurboGit TurboGit added this to the 3.2 milestone Jan 4, 2020
@phweyland
Copy link
Contributor Author

3.2... end of the year. :(

@TurboGit
Copy link
Member

TurboGit commented Jan 5, 2020

@phweyland : Don't be sad, it's an open project we can discuss everything. I put 3.2 because I feel this could wait but we can reconsider. Maybe for 3.0.1 or 3.0.2 ?

@phweyland
Copy link
Contributor Author

There are 2 points in that PR.
I had left the first one on the to do list. That's the title of the PR.
The second one comes from an issue faced by a user for a use case I hadn't considered (do not export exif except some of them), issue #3944.
There is not urgency, but there is no more reason to wait.
If not an issue for you, 3.0.1 would be fine.

@TurboGit
Copy link
Member

TurboGit commented Jan 5, 2020

Manually merged on master and 3.0.1 branch.

@TurboGit TurboGit modified the milestones: 3.2, 3.0.1 Jan 5, 2020
@TurboGit TurboGit closed this Jan 5, 2020
@phweyland phweyland deleted the export-tags branch January 8, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: enhancement current features to improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants