Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changed tags not saved in db #4112

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

phweyland
Copy link
Contributor

@phweyland phweyland commented Jan 14, 2020

table used_tags was not used anymore but at start time dt was still synchronizing data.tags with used_tags, removing some changes made on tags.

table used_tags is now removed.

fix issue #4034

@TurboGit TurboGit self-requested a review January 14, 2020 15:02
@TurboGit TurboGit self-assigned this Jan 14, 2020
@TurboGit TurboGit added bugfix pull request fixing a bug scope: DAM managing files, collections, archiving, metadata, etc. labels Jan 14, 2020
@TurboGit TurboGit added this to the 3.0.1 milestone Jan 14, 2020
@phweyland
Copy link
Contributor Author

If that helps to reproduce the issue: it was visible when one changes the name / path of an existing tag.
After restarting dt the old tag is recreated.
The other changes (new tag, tag property) were kept.

@TurboGit
Copy link
Member

Works for me!

@TurboGit TurboGit merged commit 6d897ea into darktable-org:master Jan 14, 2020
@phweyland phweyland deleted the tag-fix branch January 14, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug scope: DAM managing files, collections, archiving, metadata, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants