Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the moving lower border in clipping.c #5569

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Fix the moving lower border in clipping.c #5569

merged 1 commit into from
Jun 20, 2020

Conversation

GrahamByrnes
Copy link
Contributor

See #5558.

I'm not sure if it fixes the freaky box-that-crawls effect, but it does seem to fix the lower border that moves.

@elstoc
Copy link
Contributor

elstoc commented Jun 19, 2020

Looks like that's resolved both issues for me. Thanks @GrahamByrnes.

@TurboGit TurboGit self-requested a review June 20, 2020 06:54
@TurboGit TurboGit added this to the 3.2 milestone Jun 20, 2020
@TurboGit TurboGit added the bugfix pull request fixing a bug label Jun 20, 2020
@TurboGit
Copy link
Member

Indeed, never saw this issue as I never resize by dragging the side. I only use the corners. Good to see this fixed for the next major release.

@TurboGit TurboGit merged commit 2a3aef5 into darktable-org:master Jun 20, 2020
@AxelG-DE
Copy link

@TurboGit it was also visible when you dragged the corners, but really strong only if you go forth and back. one time you just thought "ooops I did a mistake" :)

@GrahamByrnes solves the issue with bottom-move up as well, the magic one, was not reliably reproducible. Thanks for fast reaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants