Soft deprecated #6915
Soft deprecated #6915
Conversation
…ated). Those were not listed anyway. Code clean-up.
message is shown on top of the widget content if defined
otherwise there will be no way to access them for "soft" deprecation
AlicVB
added
difficulty: average
| @@ -112,6 +112,11 @@ int flags() | |||
| return IOP_FLAGS_DEPRECATED | IOP_FLAGS_ONE_INSTANCE | IOP_FLAGS_PREVIEW_NON_OPENCL; | |||
| } | |||
|
|
|||
| const char *deprecated_msg() | |||
| { | |||
| return _("This module is deprecated."); | |||
There was a problem hiding this comment.
Use color mapping module instead
(color mapping is basically color transfer v2)
There was a problem hiding this comment.
see PR #6929 thanks for the info !
|
it's a bug... that'll be fixed soon :) |
|
In addition to what chhil pointed out, every non-deprecated module now has a blank space just below its title bar when expanded. |
|
both bugs should be fixed now in master. Thanks for the report ! |
|
fix confirmed for both bugs |
|
Just got this.... current master 3.3.0+1652~gf4d6d9920
|
|
Expected as you are on the deprecated module group if I see correctly the top of the image. |
|
But how it looks is very misleading... |
|
@chhil : seems like a bug. Lens is not deprecated and you doesn't seems to be on the deprecated preset... You have only 1 group shown... I guess you have set the pref to only show search box. right ? if so, I'm currently fixing this ! |
|
I had a clean fresh install, and that big on/off button looked odd. I had got a similar thing for crop (typed crop in the search box) too when I pasted the image with a red label, you could check that too. I have show both (module groups and search). |
|
but in that case, why do you have only the "active modules" group ? |
|
I think when I install there is no selection and it only shows active modules.
Once I select a group one then there is no way to get that big central active modules. After selecting "all modules" |
|
So... you've found 2 bugs in one it seems :) I'll take care ! |
|
Do check @aurelienpierre s new modulegroup pteset fix , may be related. |
this close #6912 , this fix #6907
Here is some refinement on top of @TurboGit PR #6912
it create a special modulegroups preset with all recently deprecated modules.
So this modules are still accessible until next release when they will disappear from modules groups, except for old edit using them.
That way, it let some time to users to adapt their workflow accordingly.
Warning messages are show on top of each modules, with a proposal of replacement modules.
@aurelienpierre : can I ask you to review all the deprecated message inside modules ? Most are just copy-paste of some of your comments around... eventually we can even add the reason of deprecation but I'm not sure it's worth the pain...
@TurboGit : thanks for the base implementation