Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[presets] allow mass preset export #7405

Merged
merged 3 commits into from Dec 23, 2020
Merged

[presets] allow mass preset export #7405

merged 3 commits into from Dec 23, 2020

Conversation

johnny-bit
Copy link
Member

Allow export of all user-defined presets

Additionally allows import of multiple presets at once

Fixes #2383

@johnny-bit
[presets] allow mass preset export
00a5b05 
Allow export of all user-defined presets

Additionally allows import of multiple presets at once

Fixes darktable-org#2383
@johnny-bit
[presets] fix spacing issues
1ffd1ba
@johnny-bit johnny-bit mentioned this pull request Dec 22, 2020
Closed
@TurboGit TurboGit added this to the 3.6 milestone Dec 23, 2020
@TurboGit TurboGit self-requested a review December 23, 2020 10:59
@TurboGit TurboGit added the feature: enhancement current features to improve label Dec 23, 2020
@TurboGit
Copy link
Member

Works for me, we need a bit of CSS to add a little margin between the export/import buttons at the bottom of the window though.

@johnny-bit : can you do that ? @Nilvus : may help if you are not fluent in CSS.

TurboGit
TurboGit requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CSS work needed.

@johnny-bit
Copy link
Member Author

CSS done :D

@TurboGit
Copy link
Member

Works for me. I have planned this for 3.6 but maybe we could have this in 3.4.1 or later, that's your call.

@TurboGit TurboGit merged commit 4fcfe82 into darktable-org:master Dec 23, 2020
@johnny-bit johnny-bit deleted the issue2383_exportpresets branch December 23, 2020 12:16
@johnny-bit
Copy link
Member Author

3.6 is fine for me for this small thingie. 3.4.1 is cool too - it's relatively small change. Either way I have to make PR for dtdocs...

@johnny-bit johnny-bit mentioned this pull request Dec 27, 2020
Merged
@johnny-bit
Copy link
Member Author

dtdocs pr here: darktable-org/dtdocs#185

@MStraeten MStraeten mentioned this pull request Dec 28, 2020
Closed
@elstoc elstoc added documentation-pending a documentation work is required documentation-complete needed documentation is merged in dtdocs and removed documentation-pending a documentation work is required labels Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit requested changes

Assignees
No one assigned
Labels
documentation-complete needed documentation is merged in dtdocs feature: enhancement current features to improve
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

Usability: export all dtpresets
3 participants
@johnny-bit @TurboGit @elstoc