add ability to use exif data for paths when importing from a camera #793
Conversation
jakeprobst
force-pushed
the
importexif
branch
2 times, most recently
from
c04b51b
to
959fc1c
Compare
|
Did this ever get merged into master? I also have a vested interest in making this work as not having it really complicates my workflow. Thank you! |
|
It was never merged as far as I know. |
|
Since we are already in freeze, it definitely won't be merged at least until after 2.0 release :( |
|
well, someone post in this thread when I should work on this so I get an email to remind me. |
|
Thank you both for your quick responses. Jake: Any chance you could sync up your fork with the latest master so we can at least use your work until it actually gets merged? I pulled it tonight and did have to manually merge exif.cc with the latest version to get it all to build. The rest of the files appeared to merge without issue. Thanks again. |
|
I'm also very interested in this feature: too bad it cannot be merged for the upcoming 2.0 release. |
|
@jakeprobst, as you had requested, if you want to update your pull request: darktable 2.0 has just been released with a bunch of great new features! https://www.darktable.org/2015/12/darktable-2-0-released/ |
|
We really must merge this PR before next major release :) |
|
Agreed! On Thu, Dec 31, 2015 at 12:32 PM, Roman Lebedev notifications@github.com
|
|
Ok it should be good to merge now. |
| size_t size; | ||
|
|
||
| gp_file_new(&camfile); | ||
| gp_camera_file_get(cam->gpcam, folder, filename, GP_FILE_TYPE_NORMAL, camfile, NULL); |
There was a problem hiding this comment.
In all other places return value of gp_camera_file_get() is checked
|
updated |
| @@ -874,7 +876,23 @@ gboolean _camera_initialize(const dt_camctl_t *c, dt_camera_t *cam) | |||
| return TRUE; | |||
| } | |||
|
|
|||
|
|
|||
| time_t _get_exif_time_from_data(uint8_t* data, unsigned long size) | |||
jakeprobst
force-pushed
the
importexif
branch
from
2df2aa9
to
a0ff580
Compare
|
updated |
|
any chance this can be merged soon? |
|
Did this ever get merged? |
| static time_t _get_exif_time_from_data(uint8_t* data, unsigned long size) | ||
| { | ||
| dt_image_t img; | ||
| dt_exif_read_from_blob(&img, data, size); |
There was a problem hiding this comment.
Don't use that, it has side effects, like writing stuff to database. Instead add something like dt_exif_get_datetime() to common/exif.cc which does things similar to dt_exif_get_color_space().
| dt_print(DT_DEBUG_CAMCTL, "[camera_control] import failed: %s\n", gp_result_as_string(res)); | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
This might be a good place to g_file_free(camfile).
|
Hi, could you fix the issues addressed and rebase on current master? We are freezing for 2.2 soonish and I would really like to have this finally merged. |
|
I did some cleanup myself and merged it. Finally. After almost 2 years. I feel sorry for taking so long. Thank you again for your work. |
So I am really bad at git and when I was trying to get the previous pull request to merge I deleted the entire branch. 4th times the charm, or something.
#759 http://www.darktable.org/redmine/issues/8415