Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify workflow section. #312

Closed
wants to merge 5 commits into from

Conversation

matt-maguire
Copy link
Contributor

Now that scene-referred workflow is the darktable default, this PR proposes to simplify the workflow overview section, and align it to the new modules available in DT 3.6/3.7. Detailed/technical non-recommended module information has been pushed to an appendix.

# choosing a workflow

When processing an image, a sequence of processing modules is applied. This sequence is known as the [pixelpipe](../../darkroom/pixelpipe/_index.md).
When processing an image, the order in which you make adjustments to modules is not necessarily the same as the order in which the modules appear in the pixel pipe. The following diagram shows key modulesin the pixel pipe that are typically involved in basic processing of an image, and underneath are numbers showing the order in which you would normally adjust those modules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an awkward sentence; I tried to rephrase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt-maguire you have a typo:

diagram shows key modulesin the pixel pipe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that typo was removed when I reworded the sentence.

@elstoc elstoc added this to the 3.8 milestone Aug 7, 2021

Two default workflows are offered in darktable, which define the default starting point for your edits:
3. The [**_crop and rotate_**](../../../module-reference/processing-modules/crop-rotate.md) module can now be used to straighten the image and frame it correctly. You may also want to use the [_perspective correction_](../../module-reference/processing-modules/perspective-correction.md) module to apply some keystone correction so that vertical and horizontal features in the images are properly aligned. This is the digital equivalent of using a tilt-shift lens, which is commonly used when shooting images of architecture.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crop and rotate is deprecated and perspective correction has been renamed to rotate and perspective


A third option is to set the default workflow to _none_. In this case, the scene-referred workflow module order will be used by default but none of the above modules will be automatically applied. It is up to the user to arrange for appropriate tone mapping and reorder the modules where required. You can change your default workflow in [preferences > processing > auto-apply pixel workflow defaults](../../preferences-settings/processing.md).
5. The [**_filmic rgb_**](../../module-reference/processing-modules/filmic-rgb.md) module is now used to do a global tone mapping on the image, where we fix up the shadows and highlights in the image. First we set the white relative exposure (the auto picker next to the slider can be helpful if your image contains pure white regions). Adjust the black relative exposure if the blacks are too washed out or too crushed (it is best to do this manually, as the black auto picker can be sensitive to noise and unreliable). The _filmic rgb_ module will set the overall tone mapping for the image; to make finer adjustments to specific areas of the image, we recommend to use the [_tone equalizer_](../../module-reference/processing-modules/tone-equalizer.md) module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps drop "and unreliable"? The black picker is definitely sensitive to noise.

: Used to add light to a scene, this module again uses blurs in Lab space. The _tone equalizer_ works in linear space, or you can also achieve a similar effect by using the _exposure_ module with a [drawn mask](../../darkroom/masking-and-blending/masks/drawn.md).

[_bloom_](../../module-reference/processing-modules/bloom.md)
: _prefer [tone equalizer](../../module-reference/processing-modules/tone-equalizer.md) (or [exposure](../../module-reference/processing-modules/exposure.md))_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diffuse or sharpen has a bloom preset.

@elstoc
Copy link
Contributor

elstoc commented Jul 12, 2022

I think this whole PR is essentially superseded by #349 now and should be closed.

@elstoc elstoc closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants