New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rawspeed: SONY ILCE-7C support #250
Conversation
Part [2/2] of darktable-org/darktable#6669 Camera info was extracted with dngmeta.sh and Adobe DNG Converter 13.0 (Macintosh)
Codecov Report
@@ Coverage Diff @@
## develop #250 +/- ##
========================================
Coverage 60.71% 60.71%
========================================
Files 234 234
Lines 12594 12594
========================================
Hits 7646 7646
Misses 4948 4948
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
The cam_xyz info seems to differ from libraw's (whereas it is consistent on another camera). I don't know how either is generated. This results in a different "camera reference" white balance on darktable. libraw's cam_xyz = [[ 0.5271, -0.0712, -0.0347], [-0.6153, 1.3653, 0.2763],[-0.1601, 0.2366, 0.7242]] (obtained with rawpy 0.17, libraw 0.20.2) darktable's adobe_xyz_to_cam (from rawspeed) = [[0.737399995, -0.238900006, -0.0551000014], [-0.543500006, 1.31620002, 0.251899987], [-0.100599997, 0.179499999, 0.655200005]] |
The basic matrix comes form the ColorMatrix2 of the DNG produced by the Adobe converter, and is the same for both libraries. https://github.com/LibRaw/LibRaw/blob/master/src/tables/colordata.cpp libraw could be additionally multiplying this by the equivalent of the DNG CameraCalibration2 matrix and/or the AnalogBalance matrix (no idea how it gets these from the ARW) which can also differ per camera unit and per shot (this is outlined in the DNG spec as XYZtoCamera = AB * CC * CM), while rawspeed does not (i.e. I guess it assumes AB and CC are identity). |
Et voilà ! Again, no idea if |
Hang on, being too smart here - this matrix returned by libraw looks suspiciously like the ILCE-7 one, so this could be just a loose matching bug/fall-though? ILCE-7C matrix was added after 0.20.2 it seems (202101 snapshot)... |
Indeed you are right! I get the same value as rawspeed / exiv2 after upgrading libraw to 0.20.2.r81.gadcb898a (current git master) |
Part [2/2] of darktable-org/darktable#6669
Camera info was extracted with dngmeta.sh and Adobe DNG Converter 13.0 (Macintosh)
Update at Sun, 08 Nov 2020 02:35:01 +0800:
output from dngmeta.sh