HideButton not hiding the whole button #1

Open
compojoom opened this Issue Apr 18, 2011 · 3 comments

Projects

None yet

2 participants

@compojoom

Using the hideButton function doesn't hide the button, but the text in the button.

I think that the hiddenButton class should be added to the label and not on the input itself.

@compojoom

I've changed the hideButton function to this:

hideButton: function(title) {
if(this.buttons[title]) this.buttons[title].getParent().addClass('hiddenButton');
return this.buttons[title];
}
and now it appears that the buttons is properly hidden, but I'm not 100% sure that it doesn't brake something else. :)

@compojoom compojoom closed this Apr 18, 2011
@compojoom compojoom reopened this Apr 18, 2011
@SitePenDavidWalsh
Contributor

Weird...can you add a test case or link to an example? Possibly at jsfiddle?

@compojoom

There you go:
http://jsfiddle.net/compojoom/pu2aN/1/

Hope you don't mind that I've copied your css stylesheet and have added the js resource directly from your page.

Cheers,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment