Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization #61

Closed
alanfriedman opened this issue Dec 15, 2017 · 16 comments
Closed

Internationalization #61

alanfriedman opened this issue Dec 15, 2017 · 16 comments

Comments

@alanfriedman
Copy link
Collaborator

@alanfriedman alanfriedman commented Dec 15, 2017

Hi Darkwire users,

We are planning to internationalize all content to support our non-English speaking users. Please vote below for the language you'd most like to see translated first, or list a different language in the comments. We'll use this to help prioritize translation.









@Invictaz
Copy link

@Invictaz Invictaz commented Dec 20, 2017

Where is Dutch?

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Dec 20, 2017

@Invictaz I'll take that as a +1 for Dutch

Loading

@tux-tn
Copy link
Contributor

@tux-tn tux-tn commented Dec 21, 2017

Loading

@VonKavalier
Copy link
Contributor

@VonKavalier VonKavalier commented Dec 21, 2017

I can help for a french translation too :)

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Dec 23, 2017

Thanks everyone for the feedback, and @tux-tn and @VonKavalier we'll likely take you up on that offer.

As for the implementation there are a few options:

  • URL path - darkwire.io/fr/room-id
  • Subdomain - fr.darkwire.io/room-id
  • Settings stored in cookie/local storage - darkwire.io/room-id

Any preferences?

Loading

@VonKavalier
Copy link
Contributor

@VonKavalier VonKavalier commented Dec 23, 2017

Nice, I'll be ready when you are 🙂
And for the implementation I'd go for a cookie/local storage, because I see it easier to share a room with a non French person for example.

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Jun 16, 2019

@tux-tn @VonKavalier We could use your help translating Darkwire to French! You can find the translation file here. Would love to merge a PR!

Loading

@VonKavalier
Copy link
Contributor

@VonKavalier VonKavalier commented Jun 16, 2019

With pleasure ! I'll try to work on it today :)

Loading

@VonKavalier
Copy link
Contributor

@VonKavalier VonKavalier commented Jun 16, 2019

Here is the PR : #87

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Jun 16, 2019

Thanks @VonKavalier! Enabling French now: #88

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Jun 16, 2019

@Invictaz Would you be able to help with the Dutch translations?

Loading

@Invictaz
Copy link

@Invictaz Invictaz commented Jun 23, 2019

@alanfriedman Sure here it is. Not sure if I translated every sentence.

nl.txt

Loading

@Invictaz
Copy link

@Invictaz Invictaz commented Jul 23, 2019

@alanfriedman Did you receive it?

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Aug 24, 2019

@Invictaz Sorry for the delayed response. I was able to see the HTML but would you mind moving it to JSON format. This recent PR is a great example of what we're looking for. Thank you for your time and contributions!

Loading

@Invictaz
Copy link

@Invictaz Invictaz commented Apr 7, 2020

@alanfriedman I forgot about this. Sorry. Shall I open a new issue on the Dutch translation. Or will you reopen this.

Loading

@alanfriedman
Copy link
Collaborator Author

@alanfriedman alanfriedman commented Apr 8, 2020

@Invictaz No problem. Feel free to open a new issue for Dutch. This was just a poll to get a feel for our users' language preferences.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants