Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions to "initWithObjects: count:" #1

merged 1 commit into from Jun 17, 2019
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

14 NSSet.m
@@ -269,6 +269,20 @@ - (id)initWithCapacity:(NSUInteger)capacity

- (id)initWithObjects:(const id [])objects count:(NSUInteger)cnt
if (objects == nil && cnt != 0) {
[NSException raise:NSInvalidArgumentException
format:(NSString *)CFSTR("The object array is nil while the count is not zero")];

// This probably isn't the most efficent way to error check, but I can't think of a better way to implement this.
for (int i = 0; i < cnt; i++) {
id value = objects[i];
if (value == nil) {
[NSException raise:NSInvalidArgumentException
format:[(NSString *)CFStringCreateWithFormat(NULL,NULL,CFSTR("The object at objects[%d] is nil."),i) autorelease]];

if (self == mutablePlaceholder)
CFMutableSetRef set = CFSetCreateMutable(kCFAllocatorDefault, cnt, &sNSCFSetCallBacks);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.