fix: Various kernel fixes - #1062
Merged
facekapow merged 5 commits intoNov 15, 2021
Merged
Conversation
Additional flavors are implemented: PIDTASKINFO, PIDTASKALLINFO, PIDLISTTHREADS. Furthermore, PIDTBSDINFO gets a valid pbi_start_tvsec and pbi_start_tvusec
Linux and BSD siginfo_t has different layouts, making processes calling waitid confused about the output.
Member
|
LGTM. Anyone else wants to review? |
facekapow
approved these changes
Nov 15, 2021
facekapow
left a comment
facekapow
left a comment
Member
There was a problem hiding this comment.
LGTM. My only concern was the SIG_IGN change affecting LLDB, but doing some testing with an old LLDB version (one that was actually working) shows that it still works fine.
Contributor
Author
|
@facekapow @LubosD Can you review the last commit? It's simply some reexported symbols in |
facekapow
requested changes
Nov 15, 2021
facekapow
left a comment
facekapow
left a comment
Member
There was a problem hiding this comment.
Just a small issue with re-exporting dyld_stub_binder. Other than that, LGTM.
trungnt2910
force-pushed
the
dev/trungnt2910/run-dotnet/misc
branch
from
November 15, 2021 16:06
a0df77a to
cc30ecd
Compare
Some libraries expect special symbols forwarded to CoreServices, else dlopen will fail.
trungnt2910
force-pushed
the
dev/trungnt2910/run-dotnet/misc
branch
from
November 15, 2021 16:10
cc30ecd to
a1338a4
Compare
facekapow
approved these changes
Nov 15, 2021
Contributor
Author
|
Thanks so much! This pull request wouldn't have been possible without your mentoring! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes are made in order to
runmakedotnetproperlydotnethalf-runnable.proc_info:
_proc_pidinfo_tbsdinfowaitid
siginfo_tbetween Linux and BSD, allowing processes to access valid data.SIGCHLD
dotnet). AsSIGCHLDis not configured withSIG_IGNon real MacOS, we should not do that on Darling, either.