From 740d45f9b28359a3e38358fc69151f27120aaf5f Mon Sep 17 00:00:00 2001 From: UnvorherSeba Date: Mon, 17 Feb 2014 18:16:17 +0100 Subject: [PATCH] Fix missing if condition causing FATAL with 8i .. this time with ALL the brackets --- lib/Ora2Pg.pm | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/Ora2Pg.pm b/lib/Ora2Pg.pm index 5d7e8f81..34f220be 100644 --- a/lib/Ora2Pg.pm +++ b/lib/Ora2Pg.pm @@ -4240,14 +4240,15 @@ SELECT COLUMN_NAME, DATA_TYPE, DATA_LENGTH, NULLABLE, DATA_DEFAULT, DATA_PRECISI FROM $self->{prefix}_TAB_COLUMNS $condition ORDER BY COLUMN_ID END - if(!$sth) { - my $ret = $self->{dbh}->err; - if (!$recurs && ($ret == 942) && ($self->{prefix} eq 'DBA')) { - $self->logit("HINT: Please activate USER_GRANTS or connect using a user with DBA privilege.\n"); - $self->{prefix} = 'ALL'; - return $self->_column_info($table, $owner, 1); - } - $self->logit("FATAL: " . $self->{dbh}->errstr . "\n", 0, 1); + if(!$sth) { + my $ret = $self->{dbh}->err; + if (!$recurs && ($ret == 942) && ($self->{prefix} eq 'DBA')) { + $self->logit("HINT: Please activate USER_GRANTS or connect using a user with DBA privilege.\n"); + $self->{prefix} = 'ALL'; + return $self->_column_info($table, $owner, 1); + } + $self->logit("FATAL: " . $self->{dbh}->errstr . "\n", 0, 1); + } } $sth->execute or $self->logit("FATAL: " . $self->{dbh}->errstr . "\n", 0, 1);