Make the build reproducible #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] we noticed that ora2pg could not be built reproducibly. This is because it generates a comment in a config file using '$$' in an attempt to get a literal '$' character. But '$$' inserts the process PID (!) of the build process into the file instead. This was originally filed in Debian as #972336 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/972336
|
I have merged your PR but there was a mistake in your patch that I have fixed with commit 8337c97. Actually we want a double dollar sign not a single one. Thanks Chris. |
|
Hi @darold - cheers, I must have assumed "delimiter" referred to the Perl/whatever regex delimiter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort I noticed that
ora2pgcould not be built reproducibly.This is because it generates a comment in a config file using
$$in an attempt to get a literal$character. But$$inserts theprocess PID (!) of the build process into the file instead.
This was originally filed in Debian as #972336.