add PCTFREE to FILLFACTOR conversion

[Maxime2]

I see conversion PCTFREE to FILLFACTOR has been semi-implemented for parsing schema from an input file, though a bit incorrect. This pull-request fix it and makes conversion PCTFREE to FILLFACTOR for reading schema directly from Oracle DB.

[darold]

Hi Maxim,

For your information commit c699fd6 change the behavior of your patch:

Limit translation of PCTFREE into FILLFACTOR when PCTFREE is upper than the
Oracle default value: 10. With PostgreSQL 100 (complete packing) is the default.

I think it is important to preserve the default bevahior related to each SGBD.

Regards,

[Maxime2]

Hi Gilles,

PCTFREE and FILLFACTOR are complementary to the value of 100% for each other, i.e.
FILLFACTOR = 100 - PCTFREE

Since FILLFACTOR must be 10 or more, then 100 - min(90, PCTFREE) ensures FILLFACTOR >= 10 as 90 is the maximum value of min(90, PCTFREE).

And thus additional check in if statement around it is redundant.

[darold]

Yes I know. The problem is that Oracle have a default PCTFREE to 10% but PostgreSQL have a default FILLFACTOR to 100%. With your patch that mean that all PostgreSQL tables will have a FILLFACTOR to 90 which is not exactly the default for PostgreSQL. My patch just apply your FILLFACTOR conversion when PCTFREE > 10.

For people who want to force the default to 90 we can add a configuration directive that can force the FILLFACTOR to the wanted value.