Fix a special case when url variables contain protocol/schema#248
Merged
Conversation
kkHAIKE
force-pushed
the
fix_variable_have_schema
branch
from
8d2c05e to
edfd2de
Compare
kkHAIKE
changed the title
kkHAIKE
changed the title
…tute vars before ensuring the protocol is present, so this isnt useful.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g. BASE_URL=https://foo.com
It's inappropriate to use
ensure_protocolprematurely; it should be deferred until afterapply_template.