Skip to content

When generating a curl command line, use -d to carry form data#252

Merged
darrenburns merged 4 commits into
darrenburns:mainfrom
kkHAIKE:fix_curl_form
Apr 13, 2025
Merged

When generating a curl command line, use -d to carry form data#252
darrenburns merged 4 commits into
darrenburns:mainfrom
kkHAIKE:fix_curl_form

Conversation

@kkHAIKE

@kkHAIKE kkHAIKE commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

curl's -F option generates multipart/form-data requests

And optimized curl data parsing to support multiple data parameters

@kkHAIKE kkHAIKE changed the title Send POST form data with -d When generating a curl command line, use -d to carry form data Apr 11, 2025
@darrenburns
darrenburns requested a review from Copilot April 13, 2025 09:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/posting/importing/curl.py:115

  • [nitpick] The flag 'is_multipart_data' is introduced but is not used in subsequent logic. Consider either integrating its usage or removing it if it serves no purpose.
self.is_multipart_data = False

src/posting/importing/curl.py:138

  • Ensure that all collected data arguments, including --data-urlencode, are correctly flattened. Consider edge cases where an empty value or list might affect the final join operation.
args.data_urlencode,

@darrenburns darrenburns left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again :)

@darrenburns
darrenburns merged commit 27a250c into darrenburns:main Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants