This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Fix frozen spinner #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #60 The `late final` field isn't instantiated until it is read, so without forcing instantiation in the constructor there is no timer updating the display. Move initialization back into the constructor. Other cleanup: - Remove the `_index` fields since it is otherwise identical to `_timer.ticks`. - Use a Github Action config that more closely matches our other packages. - Replace `homepage` with `repository` in the pubspec. There are no existing tests for the spinner, and adding one would be a large task - this code was not written with testability in mind. For now leave this untested.
Contributor
|
I believe this change also needs to be fixed 2fbb4eb#diff-0dab707dd5561665494c8ed4794f8c69d076e372014573885af1eb48e70eef71L261 |
Contributor
Author
|
The one in |
Contributor
ah ok I see it changed from |
jakemac53
approved these changes
May 5, 2021
Contributor
|
Thanks for following up on dart-lang/tools#821 ! |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
Fixes dart-lang/cli_util#60 The `late final` field isn't instantiated until it is read, so without forcing instantiation in the constructor there is no timer updating the display. Move initialization back into the constructor. Other cleanup: - Remove the `_index` fields since it is otherwise identical to `_timer.ticks`. - Use a Github Action config that more closely matches our other packages. - Replace `homepage` with `repository` in the pubspec. There are no existing tests for the spinner, and adding one would be a large task - this code was not written with testability in mind. For now leave this untested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/tools#821
The
late finalfield isn't instantiated until it is read, so withoutforcing instantiation in the constructor there is no timer updating the
display. Move initialization back into the constructor.
Other cleanup:
_indexfields since it is otherwise identical to_timer.ticks.packages.
homepagewithrepositoryin the pubspec.There are no existing tests for the spinner, and adding one would be a
large task - this code was not written with testability in mind. For now
leave this untested.