This repository was archived by the owner on Oct 17, 2024. It is now read-only.
Stop percent-encoding of numbers.#4
Merged
nex3 merged 1 commit intodart-archive:masterfrom Aug 8, 2016
DanTup:master
Merged
Conversation
RFC 3986 states that numbers are unreserved characters: Characters that are allowed in a URI but do not have a reserved purpose are called unreserved. These include uppercase and lowercase letters, decimal digits, hyphen, period, underscore, and tilde. unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~" [...] For consistency, percent-encoded octets in the ranges of ALPHA (%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E), underscore (%5F), or tilde (%7E) should not be created by URI producers
Contributor
Contributor
|
Sorry for the delay, I'm back from vacation now. I have also made a similar patch CL at https://codereview.chromium.org/2225763002/ (although your CL seems to have better testing!) |
Contributor
Author
|
@lrhn Cool; you're free to just trash this PR if you've already pushed code, as long as it's fixed I'm happy :-) |
Contributor
|
I'm going to merge in this one, since it has tests and I think the test is a little clearer. |
Contributor
Author
|
Great; thanks for pushing this out in a release already! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 3986 states that numbers are unreserved characters:
There were no tests or code specifically handling numbers so I believe this is just an oversight. This change adds numbers to the test of reserved characters as well as a couple of the additional tests that had alpha characters in.
This fixes dart-lang/core#254.
I've signed the CLA but I'm not sure how to submit this for review (the contributing file doesn't explain much); is that done here in the PR or should do I need to do something to add this to codereview.chromium.org system?