This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Implement eol_at_end_of_file rule #2762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
reviewed
Jul 8, 2021
asashour
force-pushed
the
eol_last
branch
2 times, most recently
from
6a19857 to
ad4b32c
Compare
bwilkerson
reviewed
Jul 9, 2021
Contributor
bwilkerson
left a comment
bwilkerson
left a comment
There was a problem hiding this comment.
What do you think of extending this to also check that there aren't multiple eol markers in a file?
I can see the benefit in terms of cleanliness. The only downside I can see is that it might trigger when the user adds a couple of blank lines at the end of the file just before typing a new declaration. I suspect those false positives would be acceptable and rare because most people will type the "\n\nclass" fast enough that the linter wouldn't even run when the file's in a bad state.
pq
reviewed
Jul 9, 2021
bwilkerson
approved these changes
Jul 9, 2021
Contributor
bwilkerson
left a comment
bwilkerson
left a comment
There was a problem hiding this comment.
Thanks for the contribution, and thanks for your patience with the review comments. We appreciate both.
Contributor
|
See also: dart-lang/sdk#58450. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
eol_at_end_of_filerule.Fixes dart-lang/sdk#58445