From 16e26074d34177dabc4ccd1dfdadc475532e88dd Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 10 May 2023 11:16:41 -0700 Subject: [PATCH 1/2] blast_repo fixes no-response --- .github/workflows/no-response.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/no-response.yml b/.github/workflows/no-response.yml index fdc1c6a..ac3e456 100644 --- a/.github/workflows/no-response.yml +++ b/.github/workflows/no-response.yml @@ -8,8 +8,8 @@ on: issue_comment: types: [created] schedule: - # Schedule for five minutes after the hour, every hour - - cron: '5 * * * *' + # Every day at 8am + - cron: '0 8 * * *' # All permissions not specified are set to 'none'. permissions: @@ -27,8 +27,8 @@ jobs: daysUntilClose: 14 # Comment to post when closing an Issue for lack of response. closeComment: > - Without additional information we're not able to resolve this - issue, so it will be closed at this time. You're still free to add - more info and respond to any questions above, though. We'll reopen - the case if you do. Thanks for your contribution! + Without additional information we're not able to resolve this issue, + so it will be closed at this time. You're still free to add more + info and respond to any questions above, though. We'll reopen the + issue if you do. Thanks for your contribution! token: ${{ github.token }} From fd79c0423c149af47b9009d29b7136e91a8938dd Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 10 May 2023 11:27:14 -0700 Subject: [PATCH 2/2] update analysis and test matrix --- .github/workflows/test-package.yml | 11 ++++------- CHANGELOG.md | 4 ++++ analysis_options.yaml | 20 +------------------- pubspec.yaml | 7 +++---- test/logging_test.dart | 2 -- 5 files changed, 12 insertions(+), 32 deletions(-) diff --git a/.github/workflows/test-package.yml b/.github/workflows/test-package.yml index 2d36a3b..a9d2c98 100644 --- a/.github/workflows/test-package.yml +++ b/.github/workflows/test-package.yml @@ -13,14 +13,13 @@ env: PUB_ENVIRONMENT: bot.github jobs: - # Check code formatting and static analysis on a single OS (linux) - # against Dart dev. + # Check code formatting and static analysis. analyze: runs-on: ubuntu-latest strategy: fail-fast: false matrix: - sdk: [dev] + sdk: [stable] steps: - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab - uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f @@ -36,9 +35,7 @@ jobs: run: dart analyze --fatal-infos if: always() && steps.install.outcome == 'success' - # Run tests on a matrix consisting of two dimensions: - # 1. OS: ubuntu-latest, (macos-latest, windows-latest) - # 2. release channel: dev + # Run tests on a matrix of platforms and sdk versions. test: needs: analyze runs-on: ${{ matrix.os }} @@ -47,7 +44,7 @@ jobs: matrix: # Add macos-latest and/or windows-latest if relevant for this package. os: [ubuntu-latest] - sdk: [2.18.0, dev] + sdk: [2.19.0, stable, beta] steps: - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab - uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f diff --git a/CHANGELOG.md b/CHANGELOG.md index 9117b87..489b0eb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.1.2-wip + +* Require Dart 2.19. + ## 1.1.1 * Add a check that throws if a logger name ends with '.'. diff --git a/analysis_options.yaml b/analysis_options.yaml index ecc7948..a0097f6 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,54 +1,36 @@ # https://dart.dev/guides/language/analysis-options -include: package:lints/recommended.yaml +include: package:dart_flutter_team_lints/analysis_options.yaml analyzer: language: - strict-casts: true strict-raw-types: true linter: rules: - - always_declare_return_types - avoid_bool_literals_in_conditional_expressions - - avoid_catching_errors - avoid_classes_with_only_static_members - - avoid_dynamic_calls - avoid_private_typedef_functions - avoid_redundant_argument_values - - avoid_returning_null - avoid_returning_null_for_future - avoid_returning_this - avoid_unused_constructor_parameters - avoid_void_async - cancel_subscriptions - comment_references - - directives_ordering - join_return_with_assignment - - lines_longer_than_80_chars - literal_only_boolean_expressions - missing_whitespace_between_adjacent_strings - no_adjacent_strings_in_list - no_runtimeType_toString - - omit_local_variable_types - - only_throw_errors - package_api_docs - - prefer_asserts_in_initializer_lists - prefer_const_constructors - prefer_const_declarations - prefer_expression_function_bodies - prefer_final_locals - prefer_relative_imports - - prefer_single_quotes - - sort_pub_dependencies - test_types_in_equals - - throw_in_finally - - type_annotate_public_apis - - unawaited_futures - unnecessary_await_in_return - - unnecessary_lambdas - - unnecessary_parenthesis - unnecessary_raw_strings - - unnecessary_statements - use_if_null_to_convert_nulls_to_bools - use_raw_strings - use_string_buffers diff --git a/pubspec.yaml b/pubspec.yaml index 8921a12..089a114 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,14 +1,13 @@ name: logging -version: 1.1.1 - +version: 1.1.2-wip description: >- Provides APIs for debugging and error logging, similar to loggers in other languages, such as the Closure JS Logger and java.util.logging.Logger. repository: https://github.com/dart-lang/logging environment: - sdk: ">=2.18.0 <3.0.0" + sdk: '>=2.19.0 <4.0.0' dev_dependencies: - lints: ^2.0.0 + dart_flutter_team_lints: ^1.0.0 test: ^1.16.0 diff --git a/test/logging_test.dart b/test/logging_test.dart index 4a7d40a..f41723e 100644 --- a/test/logging_test.dart +++ b/test/logging_test.dart @@ -2,8 +2,6 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -library logging_test; - import 'dart:async'; import 'package:logging/logging.dart';