From 17ef99dcb162ac07a3d1b80fb9128cdfe63b4b9b Mon Sep 17 00:00:00 2001 From: Konstantin Shcheglov Date: Thu, 26 Jul 2018 11:35:23 -0700 Subject: [PATCH 1/2] Add 'issue' and 'reason' parameters to FailingTest. --- CHANGELOG.md | 4 ++++ lib/test_reflective_loader.dart | 7 +++++-- pubspec.yaml | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e9a5ee6..b6121a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.1.8 + +- Update `FailingTest` to add named parameters `issue` and `reason`. + ## 0.1.7 - Update documentation comments. diff --git a/lib/test_reflective_loader.dart b/lib/test_reflective_loader.dart index 5667fe3..923b03e 100644 --- a/lib/test_reflective_loader.dart +++ b/lib/test_reflective_loader.dart @@ -18,7 +18,7 @@ const _AssertFailingTest assertFailingTest = const _AssertFailingTest(); /** * A marker annotation used to annotate test methods which are expected to fail. */ -const FailingTest failingTest = const FailingTest(null); +const FailingTest failingTest = const FailingTest(); /** * A marker annotation used to instruct dart2js to keep reflection information @@ -269,8 +269,11 @@ typedef dynamic _TestFunction(); class FailingTest { /** * Initialize this annotation with the given issue URI. + * + * [issue] is a full URI describing the failure and used for tracking. + * [reason] is a free form textual description. */ - const FailingTest(String issueUri); + const FailingTest({String issue, String reason}); } /** diff --git a/pubspec.yaml b/pubspec.yaml index b4f1781..3f399ea 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: test_reflective_loader -version: 0.1.7 +version: 0.1.8 description: Support for discovering tests and test suites using reflection. author: Dart Team From e64c82093c682b44e9dbedcf610e0fd419f48a65 Mon Sep 17 00:00:00 2001 From: Konstantin Shcheglov Date: Thu, 26 Jul 2018 12:02:10 -0700 Subject: [PATCH 2/2] Update the comment. --- lib/test_reflective_loader.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_reflective_loader.dart b/lib/test_reflective_loader.dart index 923b03e..25868d9 100644 --- a/lib/test_reflective_loader.dart +++ b/lib/test_reflective_loader.dart @@ -268,7 +268,7 @@ typedef dynamic _TestFunction(); */ class FailingTest { /** - * Initialize this annotation with the given issue URI. + * Initialize this annotation with the given arguments. * * [issue] is a full URI describing the failure and used for tracking. * [reason] is a free form textual description.