This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(ts2dart): emit members for protected property parameters
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know it's not very meaningful in dart, but it's useful for TypeScript. When mixed with dart's module-private semantics, it could work okay for both. Closes dart-archive#239
caitp
changed the title
protected property parameters
caitp
changed the title
protected property parametersprotected property parameters
|
@alexeagle mind taking a look? |
|
LGTM |
|
I'll merge, but will wait until Monday to bump the release, since there's apparently a special process. |
|
Hmm, not good that we haven't published steps for anyone who needs to do a On Fri, Jul 10, 2015 at 3:29 PM Jeff Cross notifications@github.com wrote:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's not very meaningful in dart, but it's useful for TypeScript.
When mixed with dart's module-private semantics, it could work okay for
both.