This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(ts options): turn on experimentalDecorators flag by default. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript 1.5.3 release candidate throw errors on decorator usage without this flag, which makes angular2 transpilation really noisy.
| @@ -45,6 +45,7 @@ export interface TranspilerOptions { | |||
|
|
|||
| export const COMPILER_OPTIONS: ts.CompilerOptions = { | |||
| allowNonTsExtensions: true, | |||
| experimentalDecorators: true, | |||
There was a problem hiding this comment.
Generally LGTM, but shouldn't this be a change in Angular that gets sent here via the options passed in the ctor?
There was a problem hiding this comment.
Ah wait, we don't actually support that :-) Maybe we should, file an issue?
There was a problem hiding this comment.
as discussed, keeping this as it is, since don't have a single user who would want experimentalDecorators: false
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 1.5.3 release candidate throw errors on decorator usage
without this flag, which makes angular2 transpilation really noisy.