This repository was archived by the owner on Jul 16, 2023. It is now read-only.
feat: don't trigger prefer-extracting-callbacks on empty function blocks #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ookami-kb
force-pushed
the
ookami-kb/issue458
branch
from
7d4dc8d to
6a61184
Compare
ookami-kb
force-pushed
the
ookami-kb/issue458
branch
from
6a61184 to
68e1a70
Compare
dkrutskikh
approved these changes
Sep 20, 2021
| Warns about inline callbacks in a widget tree and suggests to extract them to widget methods in order to make a `build` method more readable. In addition extracting can help test those methods separately as well. | ||
|
|
||
| **NOTE** the rule will not trigger on arrow functions like `onPressed: () => _handler(...)` in order to cover cases when a callback needs a variable from the outside. | ||
| **NOTE** the rule will not trigger on: |
Member
There was a problem hiding this comment.
@ookami-kb please make PR to website repo https://github.com/dart-code-checker/website/pull/44
Contributor
Author
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 83.32% 83.34% +0.01%
==========================================
Files 188 188
Lines 3839 3843 +4
==========================================
+ Hits 3199 3203 +4
Misses 640 640
Continue to review full report at Codecov.
|
incendial
approved these changes
Sep 20, 2021
Member
incendial
left a comment
incendial
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix
[ ] New rule
[X] Changes an existing rule
prefer-extracting-callbacks(#458)[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
prefer-extracting-callbacksrule doesn't trigger on the empty block functions.Is there anything you'd like reviewers to focus on?
–