Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Conversation

@dkrutskikh
Copy link
Member

@dkrutskikh dkrutskikh commented Oct 1, 2021

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: update dependency

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Waiting https://dart-review.googlesource.com/c/sdk/+/215244

@dkrutskikh dkrutskikh requested a review from incendial October 1, 2021 19:28
@dkrutskikh dkrutskikh self-assigned this Oct 1, 2021
@dkrutskikh dkrutskikh changed the title chore: migrate on analyzer 2.4.0 WIP chore: migrate on analyzer 2.4.0 Oct 1, 2021
@dkrutskikh dkrutskikh changed the title WIP chore: migrate on analyzer 2.4.0 chore: migrate on analyzer 2.4.0 Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #483 (6eb0d2d) into master (834d689) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files         199      199           
  Lines        4129     4129           
=======================================
  Hits         3460     3460           
  Misses        669      669           
Impacted Files Coverage Δ
...ules/rules_list/no_object_declaration/visitor.dart 91.66% <0.00%> (ø)
...nalyzer/rules/base_visitors/intl_base_visitor.dart 100.00% <100.00%> (ø)
...es/rules_list/avoid_returning_widgets/visitor.dart 100.00% <100.00%> (ø)
...rules_list/avoid_unnecessary_setstate/visitor.dart 100.00% <100.00%> (ø)
...ules_list/prefer_extracting_callbacks/visitor.dart 100.00% <100.00%> (ø)
...es_list/prefer_single_widget_per_file/visitor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834d689...6eb0d2d. Read the comment docs.

@dkrutskikh dkrutskikh changed the title chore: migrate on analyzer 2.4.0 chore: migrate on analyzer 2.5.0 Oct 9, 2021
@dkrutskikh dkrutskikh merged commit 21d0785 into master Oct 10, 2021
@dkrutskikh dkrutskikh deleted the analyzer-2-4-0 branch October 10, 2021 00:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants