Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build_web_compilers for org-dartlang-app uris #2280

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
3 participants
@jakemac53
Copy link
Contributor

commented May 21, 2019

This gets hot restart working with the previous fix in dart-lang/sdk#36736.

We should probably discuss if we need to backport a 1.x fix as well.

@jakemac53 jakemac53 requested a review from natebosch May 21, 2019

@googlebot googlebot added the cla: yes label May 21, 2019

@natebosch

This comment has been minimized.

Copy link
Member

commented May 21, 2019

We should probably discuss if we need to backport a 1.x fix as well.

We don't need to. 1.x was on the analyzer ddc which isn't changing behavior.

@jakemac53 jakemac53 merged commit 7832ab3 into master May 22, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jakemac53 jakemac53 deleted the hot-reload-uris branch May 22, 2019

dart-bot pushed a commit to dart-lang/sdk that referenced this pull request May 22, 2019

Reapply "Use the full URI for DDK library debug names"
This reverts commit 3bc0ad4.

Fixes #36736

The problems with hot reload are fixed in
dart-lang/build#2280

Change-Id: I12de170423c6bfe73816172959e4bc624d9b0f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103362
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.