Experiment with running client tests #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jan 18, 2022
Co-authored-by: Jacob MacDonald <jakemac@google.com>
jakemac53
approved these changes
Jan 19, 2022
jakemac53
reviewed
Jan 19, 2022
simolus3
force-pushed
the
add-community-tests
branch
from
64fbc77
to
78f7a32
Compare
|
Looks like we are getting a lot of chrome timeout flakes, but your stuff here is working. I can restart the jobs until it's green. |
|
Yeah from my side I'm happy with the current test configuration for community tests. So if everything looks fine to you too restarting the flaky tests would be great 👍 |
natebosch
added a commit
that referenced
this pull request
May 2, 2022
Closes #3239 The character was originally `|` but was changed to `:` because the former is a special character in windows terminals. Some docs where updated with that change, but some were missed. Use `:` over `|` consistently in docs, `build.yaml`, and command line arguments in tests. Fix a utility which shortens redundant builder names to use the new separator. This utility had not been working.
natebosch
added a commit
that referenced
this pull request
May 2, 2022
Closes #3239 The character was originally `|` but was changed to `:` because the former is a special character in windows terminals. Some docs where updated with that change, but some were missed. Use `:` over `|` consistently in docs, `build.yaml`, and command line arguments in tests. Fix a utility which shortens redundant builder names to use the new separator. This utility had not been working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing purposes, I've added a tool adding necessary
dependency_overridesto an external package. Based on that, I added a simple test run for my most popular builder as a GitHub Actions workflow.