Refactor slow integration tests. #4213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
pick-port-more
branch
2 times, most recently
from
99677bc to
498cba8
Compare
davidmorgan
force-pushed
the
pick-port-more
branch
from
498cba8 to
810fb78
Compare
jensjoha
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serve_integration_testactually did not have to be in theslowtest bucket as it does not start a real server.Refactor
daemon_testinto an equivalent e2e test usingBuildRunnerTester. It's faster mostly because it reuses a small number of daemons instead of setting up / tearing down for every test case.Remove the
slowtests, remove some now-unused e2e support code.I couldn't get the
package:testsharding options to play nicely with tags, so, just shard the integration tests into three with three tags for now, I'll come back to it if it's annoying like that :)