Skip to content

Fix Dart2JS adding extraneous sourcemaps to its archive when both wasm and js are enabled. #4267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

Fix Dart2JS adding extraneous sourcemaps to its archive when both wasm and js are enabled. #4267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3561e7c
Fix skipping dart2js sourcemap files when creating a tarball
Markzipan Oct 29, 2025
2d5ec4a
bumping ver
Markzipan Oct 29, 2025
f710ff4
fixing clog
Markzipan Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build_web_compilers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 4.3.2
- Fix Dart2JS adding extraneous sourcemaps to its archive when both wasm and js are enabled.

## 4.3.1
- Fix Dart2JS sourcemaps not being written when both wasm and js are enabled.

Expand Down
6 changes: 5 additions & 1 deletion build_web_compilers/lib/src/dart2js_bootstrap.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ $librariesString
final archive = Archive();
await for (final jsFile in fileGlob.list(root: rootDir)) {
if (jsFile.path.endsWith(entrypointExtension) ||
jsFile.path.endsWith(jsEntrypointSourceMapExtension)) {
jsFile.path.endsWith(
onlyCompiler
? jsEntrypointSourceMapExtension
: dart2jsEntrypointSourceMapExtension,
)) {
// These are explicitly output, and are not part of the archive.
continue;
}
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: build_web_compilers
version: 4.3.1
version: 4.3.2
description: Builder implementations wrapping the dart2js and DDC compilers.
repository: https://github.com/dart-lang/build/tree/master/build_web_compilers
resolution: workspace
Expand Down