Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co19_2/LibTest/core/List/List_class_A01_t02 and related tests timing out on Mac for debug builds #198

Closed
sstrickl opened this issue Nov 26, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@sstrickl
Copy link
Contributor

commented Nov 26, 2018

Affected tests:

These all pull in the same file (LibTest/core/List/hugeTestLists.dart) which runs a suite of large list sorting tests from three separate imports. The combined test runs for 4-6 mins on succeeding runs, checking a few such runs, and now and again causes failures due to hitting the 8 min timeout cutoff.

If all these sorting tests are needed, they should be separated out instead of run together to avoid the combined test suite timing out sporadically, which has started to happen since this change landed. (See this log or this log for example timeouts).

@dcharkes

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

See the analysis in dart-lang/sdk#35297.

The short term solution is to split these tests into separate tests instead of combine them, and to split LibTest/core/List/sort_A01_t06.test.dart into 3 tests. This way the functionality of the lists can be tested without slowdowns.

Separately, the performance degradation when tests are combined should be investigated: dart-lang/sdk#35297

@sgrekhov sgrekhov self-assigned this Dec 6, 2018

sgrekhov added a commit that referenced this issue Dec 6, 2018

sgrekhov added a commit that referenced this issue Dec 6, 2018

Merge pull request #202 from dart-lang/issue198
Fix for #198. Split memory consuming tests into separate ones
@sgrekhov

This comment has been minimized.

Copy link
Collaborator

commented Dec 6, 2018

Fixed by b903c8b

@sgrekhov sgrekhov closed this Dec 6, 2018

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jan 7, 2019

[gardening] Mark more large list sorts as slow.
These are tests split off from _A01_t02 in the resolution to
dart-lang/co19#198.

Also removing the Timeout markers from the original tests,
since they should be smaller and thus no longer causing
timeouts.

Change-Id: I07699ae41a0c8e3f892cca5e29855b52fe7c2829
Reviewed-on: https://dart-review.googlesource.com/c/88570
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.