Fix some LibTest/io/Stdout/* tests: Wait for deletion of file before continuing the test #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…continuing the test
mkustermann
commented
Dec 13, 2018
| @@ -37,11 +37,10 @@ run_main(Encoding enc, void run(), List<int> expected) async { | |||
| run_Windows(executable, script, filename, enc) : | |||
| run_Linux(executable, script, filename, enc)). | |||
| then((ProcessResult results) async { | |||
| File fl = new File(filename); | |||
| await fl.readAsBytes().then((List<int> contents) { | |||
| fl.delete(); | |||
There was a problem hiding this comment.
This delete is asynch and needs to be awaited for!
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 13, 2018
PR dart-lang/co19#204 Change-Id: Id099b04120985d52bd2a255f82b784021d1af1df Reviewed-on: https://dart-review.googlesource.com/c/87185 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com> Auto-Submit: Martin Kustermann <kustermann@google.com>
iarkh
approved these changes
Dec 14, 2018
sgrekhov
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.