Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some LibTest/io/Stdout/* tests: Wait for deletion of file before continuing the test #204

Merged
merged 2 commits into from Dec 14, 2018

Conversation

Projects
None yet
4 participants
@mkustermann
Copy link
Member

commented Dec 13, 2018

No description provided.

@mkustermann mkustermann requested a review from sgrekhov Dec 13, 2018

@googlebot googlebot added the cla: yes label Dec 13, 2018

@@ -37,11 +37,10 @@ run_main(Encoding enc, void run(), List<int> expected) async {
run_Windows(executable, script, filename, enc) :
run_Linux(executable, script, filename, enc)).
then((ProcessResult results) async {
File fl = new File(filename);
await fl.readAsBytes().then((List<int> contents) {
fl.delete();

This comment has been minimized.

Copy link
@mkustermann

mkustermann Dec 13, 2018

Author Member

This delete is asynch and needs to be awaited for!

dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 13, 2018

[Gardening] Skip co19 tests affected by race until pull request lands
PR dart-lang/co19#204

Change-Id: Id099b04120985d52bd2a255f82b784021d1af1df
Reviewed-on: https://dart-review.googlesource.com/c/87185
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>

@sgrekhov sgrekhov requested a review from iarkh Dec 14, 2018

@iarkh

iarkh approved these changes Dec 14, 2018

@mkustermann mkustermann merged commit 6c743a6 into master Dec 14, 2018

1 check passed

cla/google All necessary CLAs are signed

@mkustermann mkustermann deleted the mkustermann-fix-io-stdout branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.