Skip to content

#2976. Add more tests for nullable and FutureOr types #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2025
Merged

#2976. Add more tests for nullable and FutureOr types #3050

merged 3 commits into from
Jan 17, 2025

Conversation

@sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jan 16, 2025

No description provided.

eernstg
eernstg reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with several comments. It looks like a handful of tests might be based on language that we shouldn't test (because it isn't normative, even though the feature specification does not mention this fact explicitly).

sgrekhov
sgrekhov commented Jan 16, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Moved tests to type inference section. Descriptions fixed. PTAL.

@sgrekhov sgrekhov requested a review from eernstg January 16, 2025 13:21
@sgrekhov sgrekhov changed the title #2976. Add tests for nullable and union types #2976. Add more tests for nullable and FutureOr types Jan 16, 2025
eernstg
eernstg reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The description is somewhat confusing to read in some tests, I'm suggesting that a few words are simply removed.

For the type_inference... tests, I think we might just as well have both some parameterized types and some raw types as the context type, now that the specification spells out both forms explicitly.

sgrekhov
sgrekhov commented Jan 17, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description updated, additional cases added

@sgrekhov sgrekhov requested a review from eernstg January 17, 2025 12:23
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Jan 17, 2025

PTAL

eernstg
eernstg approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 1a53098 into dart-lang:master Jan 17, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 31, 2025
@sgrekhov @athomas
[co19] Roll co19 to 9b05eab312a0247b890c06a05ef667e56a4534ff
d2f6a5b 
2025-01-29 sgrekhov22@gmail.com dart-lang/co19#3054. Add covariant parameters tests (dart-lang/co19#3059)
2025-01-29 sgrekhov22@gmail.com dart-lang/co19#3054. Existing tests renamed to Instance Method Closurization (dart-lang/co19#3058)
2025-01-27 sgrekhov22@gmail.com dart-lang/co19#2162. Add static member and non-redirecting factory constructor conflict test (dart-lang/co19#3056)
2025-01-27 sgrekhov22@gmail.com dart-lang/co19#2145. Update existing "Evaluation of Implicit Variable Getters" tests (dart-lang/co19#3052)
2025-01-24 sgrekhov22@gmail.com dart-lang/co19#2138. Add more tests for `call` method/getter (dart-lang/co19#3053)
2025-01-24 sgrekhov22@gmail.com dart-lang/co19#2162. Add more constructor vs. static member conflict tests (dart-lang/co19#3055)
2025-01-17 sgrekhov22@gmail.com dart-lang/co19#2976. Add more tests for nullable and FutureOr types (dart-lang/co19#3050)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ibeafe23be5d8b913db4e83b23f3820cafc3802ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406940
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgrekhov @eernstg