#3180. Add tests for dartify().
#3258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujzs
reviewed
Jul 21, 2025
| /// @assertion Object? dartify() | ||
| /// Converts a JavaScript value to the Dart equivalent if possible. | ||
| /// | ||
| /// Effectively the inverse of `NullableObjectUtilExtension.jsify`, `dartify` |
There was a problem hiding this comment.
FYI - the documentation here has been updated in the last few months to specify that certain conversions are undefined.
Contributor
Author
|
@srujzs thank you! The tests updated according to the new description.
PTAL |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 28, 2025
2025-07-24 sgrekhov22@gmail.com dart-lang/co19#3180. Add `instanceof` and `instanceOfString` tests (dart-lang/co19#3260) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add more tests for `@anonymous` annotation (dart-lang/co19#3259) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@staticInterop` tests. Part 2. (dart-lang/co19#3257) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add tests for `dartify()`. (dart-lang/co19#3258) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: Ia8539002298999a01ce8999aeee4368201219ed5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442180 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.