-
Notifications
You must be signed in to change notification settings - Fork 29
#3180. Add instanceof and instanceOfString tests
#3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not quite sure how It's possible that the compiled file isn't in the same directory as the test files so a relative path may not work. |
sgrekhov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Added tests for constructorName with . (using /root_dart/...). Please take another look.
LibTest/js_interop/JSAnyUtilityExtension/instanceOfString_A04_t02.dart
Outdated
Show resolved
Hide resolved
|
Updated. PTAL. |
2025-07-24 sgrekhov22@gmail.com dart-lang/co19#3180. Add `instanceof` and `instanceOfString` tests (dart-lang/co19#3260) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add more tests for `@anonymous` annotation (dart-lang/co19#3259) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@staticInterop` tests. Part 2. (dart-lang/co19#3257) 2025-07-22 sgrekhov22@gmail.com dart-lang/co19#3180. Add tests for `dartify()`. (dart-lang/co19#3258) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: Ia8539002298999a01ce8999aeee4368201219ed5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442180 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
I also tried to test the case where
constructorNamecontains a.but wasn’t successful. @srujzs, do you know how to import a JS class from a library into the tests? Any advice is appreciated. I tried the approach below, but it doesn’t work (module.jscontains definitions for classesAandB).