#3180. Add @JS() annotation tests. Part 3.
#3269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Jul 31, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
LGTM, awaiting further comments.
srujzs
approved these changes
Jul 31, 2025
srujzs
left a comment
srujzs
left a comment
There was a problem hiding this comment.
Feel free to ignore my comments if they're going to be addressed in a future PR.
eernstg
reviewed
Aug 1, 2025
sgrekhov
commented
Aug 1, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thank you! A good advices! I'll implement them in a separate PR.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 4, 2025
2025-08-01 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@JS()` annotation tests. Part 3. (dart-lang/co19#3269) 2025-08-01 sgrekhov22@gmail.com dart-lang/co19#3180. Add `@JS()` annotation tests. Part 2. (dart-lang/co19#3268) 2025-07-31 sgrekhov22@gmail.com dart-lang/co19#3180. Add `typeofEquals` tests (dart-lang/co19#3262) 2025-07-31 sgrekhov22@gmail.com dart-lang/co19#3180. Add more instanceOfString tests (dart-lang/co19#3264) 2025-07-29 sgrekhov22@gmail.com Fixes dart-lang/co19#3261. Update expected errors positions for CFE (dart-lang/co19#3267) 2025-07-28 sgrekhov22@gmail.com dart-lang/co19#3180. Update assertion for staticInterop tests (dart-lang/co19#3265) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I5167edcc66a25f6e626cb4d8c1f5d2b5ec4ad82a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443280 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.