From d091008d51ff586059b018d1fdd388955972d164 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Tue, 24 Oct 2023 12:35:21 -0700 Subject: [PATCH] misc cleanup (#2692) --- CONTRIBUTING.md | 4 ++-- README.md | 2 +- pkgs/dart_pad/tool/grind.dart | 2 +- pkgs/dart_services/README.md | 4 ++-- pkgs/dart_services/tool/grind.dart | 2 +- pkgs/dartpad_shared/pubspec.yaml | 2 +- pkgs/sketch_pad/lib/utils.dart | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index db7da6a64..5e4e7a5f8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,11 +65,11 @@ cd dart-services dart pub get # Change the SDK version dart-services serves to the one you currently have installed grind update-docker-version -# Begin serving the backend locally on port 8082. +# Begin serving the backend locally on port 8080. FLUTTER_CHANNEL="stable" grind serve & cd ../dart-pad -# Begin serving the front-end locally on port 8000, with the given backend on the default port 8082 this is defined in tools/grind.dart +# Begin serving the front-end locally on port 8000, with the given backend on the default port 8080 this is defined in tools/grind.dart grind serve-local-backend ``` diff --git a/README.md b/README.md index 348278070..29c197a2f 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ and Flutter. You can access it at [dartpad.dev](http://dartpad.dev). | --- | --- | --- | | [dart_pad](pkgs/dart_pad/) | The front end of DartPad. | [![dart_pad](https://github.com/dart-lang/dart-pad/actions/workflows/dart_pad.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dart_pad.yml) | | [dart_services](pkgs/dart_services/) | The backend service for DartPad. | [![dart_services](https://github.com/dart-lang/dart-pad/actions/workflows/dart_services.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dart_services.yml) | -| [dartpad_shared](pkgs/dartpad_shared/) | Common code shared between the DartPad frontend and backend. | [![dartpad_shared](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml) | +| [dartpad_shared](pkgs/dartpad_shared/) | Shared code between the DartPad frontend and backend. | [![dartpad_shared](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml) | | [samples](pkgs/samples/) | Sample code snippets for DartPad. | [![samples](https://github.com/dart-lang/dart-pad/actions/workflows/samples.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/samples.yml) | | [sketch_pad](pkgs/sketch_pad/) | An experimental redux of the DartPad UI. | [![sketch_pad](https://github.com/dart-lang/dart-pad/actions/workflows/sketch_pad.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/sketch_pad.yml) | diff --git a/pkgs/dart_pad/tool/grind.dart b/pkgs/dart_pad/tool/grind.dart index 389ef0094..f0c9e9b6c 100644 --- a/pkgs/dart_pad/tool/grind.dart +++ b/pkgs/dart_pad/tool/grind.dart @@ -50,7 +50,7 @@ Future serveLocalAppEngine() async { ConstTaskArgs('build', flags: { _debugFlag: true, }, options: { - _serverUrlOption: 'http://127.0.0.1:8082/', + _serverUrlOption: 'http://127.0.0.1:8080/', }), )) Future serveLocalBackend() async { diff --git a/pkgs/dart_services/README.md b/pkgs/dart_services/README.md index 367fb8f94..634d5b8bf 100644 --- a/pkgs/dart_services/README.md +++ b/pkgs/dart_services/README.md @@ -60,8 +60,8 @@ To run the server, run: $ FLUTTER_CHANNEL="stable" dart tool/grind.dart serve ``` -The server will run from port 8082 and export several JSON APIs, like -`/api/compile` and `/api/analyze`. +The server will run from port 8080 and export several JSON APIs, like +`/api/v3/compile` and `/api/v3/analyze`. ## Testing diff --git a/pkgs/dart_services/tool/grind.dart b/pkgs/dart_services/tool/grind.dart index 1cdbffc17..70627d67b 100644 --- a/pkgs/dart_services/tool/grind.dart +++ b/pkgs/dart_services/tool/grind.dart @@ -48,7 +48,7 @@ Future serve() async { '--channel', _channel, '--port', - '8082', + '8080', ]); } diff --git a/pkgs/dartpad_shared/pubspec.yaml b/pkgs/dartpad_shared/pubspec.yaml index f863ba7d0..9225ab7c2 100644 --- a/pkgs/dartpad_shared/pubspec.yaml +++ b/pkgs/dartpad_shared/pubspec.yaml @@ -1,5 +1,5 @@ name: dartpad_shared -description: Common code shared between the DartPad frontend and backend. +description: Shared code between the DartPad frontend and backend. publish_to: 'none' environment: diff --git a/pkgs/sketch_pad/lib/utils.dart b/pkgs/sketch_pad/lib/utils.dart index 2c48f1b9c..b65924d5c 100644 --- a/pkgs/sketch_pad/lib/utils.dart +++ b/pkgs/sketch_pad/lib/utils.dart @@ -61,7 +61,7 @@ bool hasFlutterWebMarker(String javaScript) { return true; } - // define('dartpad_main', ['dart_sdk', 'flutter_web'] + // define('dartpad_main', ['dart_sdk', 'flutter_web'] if (javaScript.contains("define('") && javaScript.contains("'flutter_web'")) { return true; }