From e8fdd4b5f8d2fc81281c9039ccf3944b1b8a937b Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 3 Apr 2024 10:33:18 -0700 Subject: [PATCH] comment out the 'unimplemented' find / find next messages (#2930) --- pkgs/sketch_pad/lib/keys.dart | 24 ++++++++++++------------ pkgs/sketch_pad/lib/main.dart | 17 ++++++++--------- pkgs/sketch_pad/lib/utils.dart | 6 ------ 3 files changed, 20 insertions(+), 27 deletions(-) diff --git a/pkgs/sketch_pad/lib/keys.dart b/pkgs/sketch_pad/lib/keys.dart index c6bc238cd..d4fb0639a 100644 --- a/pkgs/sketch_pad/lib/keys.dart +++ b/pkgs/sketch_pad/lib/keys.dart @@ -24,16 +24,16 @@ final ShortcutActivator runKeyActivator2 = SingleActivator( control: _nonMac, ); -final ShortcutActivator findKeyActivator = SingleActivator( - LogicalKeyboardKey.keyF, - meta: _mac, - control: _nonMac, -); -final ShortcutActivator findNextKeyActivator = SingleActivator( - LogicalKeyboardKey.keyG, - meta: _mac, - control: _nonMac, -); +// final ShortcutActivator findKeyActivator = SingleActivator( +// LogicalKeyboardKey.keyF, +// meta: _mac, +// control: _nonMac, +// ); +// final ShortcutActivator findNextKeyActivator = SingleActivator( +// LogicalKeyboardKey.keyG, +// meta: _mac, +// control: _nonMac, +// ); final ShortcutActivator formatKeyActivator1 = SingleActivator( LogicalKeyboardKey.keyS, @@ -65,8 +65,8 @@ const ShortcutActivator quickFixKeyActivator2 = SingleActivator( final List<(String, List)> keyBindings = [ ('Code completion', [codeCompletionKeyActivator]), - ('Find', [findKeyActivator]), - ('Find next', [findNextKeyActivator]), + // ('Find', [findKeyActivator]), + // ('Find next', [findNextKeyActivator]), ('Format', [formatKeyActivator1, formatKeyActivator2]), ('Quick fixes', [quickFixKeyActivator1, quickFixKeyActivator2]), ('Run', [runKeyActivator1, runKeyActivator2]), diff --git a/pkgs/sketch_pad/lib/main.dart b/pkgs/sketch_pad/lib/main.dart index e878cf0aa..3366b8790 100644 --- a/pkgs/sketch_pad/lib/main.dart +++ b/pkgs/sketch_pad/lib/main.dart @@ -25,7 +25,6 @@ import 'model.dart'; import 'problems.dart'; import 'samples.g.dart'; import 'theme.dart'; -import 'utils.dart'; import 'versions.dart'; import 'widgets.dart'; @@ -446,14 +445,14 @@ class _DartPadMainPageState extends State keys.runKeyActivator2: () { if (!appModel.compilingBusy.value) _performCompileAndRun(); }, - keys.findKeyActivator: () { - // TODO: - unimplemented(context, 'find'); - }, - keys.findNextKeyActivator: () { - // TODO: - unimplemented(context, 'find next'); - }, + // keys.findKeyActivator: () { + // // TODO: + // unimplemented(context, 'find'); + // }, + // keys.findNextKeyActivator: () { + // // TODO: + // unimplemented(context, 'find next'); + // }, keys.formatKeyActivator1: () { if (!appModel.formattingBusy.value) _handleFormatting(); }, diff --git a/pkgs/sketch_pad/lib/utils.dart b/pkgs/sketch_pad/lib/utils.dart index fa62a3b86..0b253209c 100644 --- a/pkgs/sketch_pad/lib/utils.dart +++ b/pkgs/sketch_pad/lib/utils.dart @@ -20,12 +20,6 @@ String titleCase(String phrase) { return phrase.substring(0, 1).toUpperCase() + phrase.substring(1); } -void unimplemented(BuildContext context, String message) { - ScaffoldMessenger.of(context).showSnackBar( - SnackBar(content: Text('Unimplemented: $message')), - ); -} - String generateSnippetName() => fluttering_phrases.generate(); RelativeRect calculatePopupMenuPosition(