New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package spec file #5

Closed
munificent opened this Issue Feb 26, 2015 · 12 comments

Comments

Projects
None yet
5 participants
@munificent
Member

munificent commented Feb 26, 2015

@lrhn has a DEP for specifying how packages are located using an explicit mapping file instead of a "packages" directory.

Repo: https://github.com/lrhn/dep-pkgspec

Note: This issue is for tracking the status of the proposal. If you would like to provide feedback on the proposal itself, please do so by filing issues on its repo.

@zoechi

This comment has been minimized.

Show comment
Hide comment
@zoechi

zoechi Mar 5, 2015

Absolute paths (including /home/someuser/...) don't look to good and won't work well with CVS.
Some environment variable interpolation could solve this.

Seems this file has to be maintained in addition to pubsec. yaml, at least when manual entries are made.

zoechi commented Mar 5, 2015

Absolute paths (including /home/someuser/...) don't look to good and won't work well with CVS.
Some environment variable interpolation could solve this.

Seems this file has to be maintained in addition to pubsec. yaml, at least when manual entries are made.

@munificent

This comment has been minimized.

Show comment
Hide comment
@munificent

munificent Mar 5, 2015

Member

Absolute paths (including /home/someuser/...) don't look to good and won't work well with CVS.

You wouldn't check this file into source control. (That's what the lock file is for.)

Seems this file has to be maintained in addition to pubsec. yaml, at least when manual entries are made.

Pub will create it for you. It's exactly analogous to the "packages" directory full of symlinks that pub currently generates for you.

Member

munificent commented Mar 5, 2015

Absolute paths (including /home/someuser/...) don't look to good and won't work well with CVS.

You wouldn't check this file into source control. (That's what the lock file is for.)

Seems this file has to be maintained in addition to pubsec. yaml, at least when manual entries are made.

Pub will create it for you. It's exactly analogous to the "packages" directory full of symlinks that pub currently generates for you.

@zoechi

This comment has been minimized.

Show comment
Hide comment
@zoechi

zoechi Mar 6, 2015

Thanks, I got it.
I wondered if there is more into it because manual entries were explicitly mentioned in the proposal.

zoechi commented Mar 6, 2015

Thanks, I got it.
I wondered if there is more into it because manual entries were explicitly mentioned in the proposal.

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd Apr 2, 2015

Member

Hi, who are we awaiting revision from? And what's a good way for me to see what revisions/updates we are waiting for?

Thanks!

Member

sethladd commented Apr 2, 2015

Hi, who are we awaiting revision from? And what's a good way for me to see what revisions/updates we are waiting for?

Thanks!

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd Apr 10, 2015

Member

Friendly ping. How can I tell what the open issues are, that need to be addressed?

Member

sethladd commented Apr 10, 2015

Friendly ping. How can I tell what the open issues are, that need to be addressed?

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd Apr 17, 2015

Member

Never mind, figured it out.

Member

sethladd commented Apr 17, 2015

Never mind, figured it out.

@iposva-google

This comment has been minimized.

Show comment
Hide comment
@iposva-google

iposva-google Apr 21, 2015

The proposal at https://github.com/lrhn/dep-pkgspec at commit be26d503e495b115e302d722d124423372af21b3 looks good to me.

I am planning to implement the handling of the packages.map handling in the standalone VM within the next two weeks.

iposva-google commented Apr 21, 2015

The proposal at https://github.com/lrhn/dep-pkgspec at commit be26d503e495b115e302d722d124423372af21b3 looks good to me.

I am planning to implement the handling of the packages.map handling in the standalone VM within the next two weeks.

@jmesserly

This comment has been minimized.

Show comment
Hide comment
Member

jmesserly commented Apr 21, 2015

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 4, 2015

Member

For tracking: here's the meta issue collecting all the implementation issues in one spot: https://code.google.com/p/dart/issues/detail?id=23372

Member

sethladd commented May 4, 2015

For tracking: here's the meta issue collecting all the implementation issues in one spot: https://code.google.com/p/dart/issues/detail?id=23372

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 12, 2015

Member

We've closed out all outstanding issues over at https://github.com/lrhn/dep-pkgspec/issues. Please take another look. Thanks!

Member

sethladd commented May 12, 2015

We've closed out all outstanding issues over at https://github.com/lrhn/dep-pkgspec/issues. Please take another look. Thanks!

@munificent munificent added accepted and removed awaiting review labels May 13, 2015

@munificent

This comment has been minimized.

Show comment
Hide comment
@munificent

munificent May 13, 2015

Member

It's accepted! I'll send out my DEP meeting notes when I get a chance with some more details.

Member

munificent commented May 13, 2015

It's accepted! I'll send out my DEP meeting notes when I get a chance with some more details.

@munificent munificent closed this May 13, 2015

@sethladd

This comment has been minimized.

Show comment
Hide comment
@sethladd

sethladd May 13, 2015

Member

Very cool, thank you!

Member

sethladd commented May 13, 2015

Very cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment