New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support assert in initializer list experiment. #639

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
4 participants
@munificent
Member

munificent commented Jun 20, 2017

Fix #522.

@munificent munificent requested a review from nex3 Jun 20, 2017

@googlebot googlebot added the cla: yes label Jun 20, 2017

@@ -103,7 +103,7 @@ class DartFormatter {
// Parse it.
var parser = new Parser(stringSource, errorListener);
parser.parseGenericMethods = true;
parser.enableAssertInitializer = true;

This comment has been minimized.

@kevmoo

kevmoo Jun 20, 2017

Member

sure the min constraint on pkg/analyzer matches this?

@kevmoo

kevmoo Jun 20, 2017

Member

sure the min constraint on pkg/analyzer matches this?

This comment has been minimized.

@munificent

munificent Jun 20, 2017

Member

I believe so, yes.

@munificent

munificent Jun 20, 2017

Member

I believe so, yes.

// new AST type.
// TODO(rnystrom): Test.
visitAssertInitializer(node) {
_simpleStatement(node, () {

This comment has been minimized.

@nex3

nex3 Jun 20, 2017

Member

What was _simpleStatement() doing here? Why is it safe to remove?

@nex3

nex3 Jun 20, 2017

Member

What was _simpleStatement() doing here? Why is it safe to remove?

This comment has been minimized.

@munificent

munificent Jun 20, 2017

Member

Adding a trailing semicolon, mainly. It was a bug, uncaught because there were no tests for it since at the time the code was written, there wasn't a published version of analyzer that supported parsing the syntax.

@munificent

munificent Jun 20, 2017

Member

Adding a trailing semicolon, mainly. It was a bug, uncaught because there were no tests for it since at the time the code was written, there wasn't a published version of analyzer that supported parsing the syntax.

@nex3

nex3 approved these changes Jun 20, 2017

@munificent munificent merged commit e04ba08 into master Jun 20, 2017

1 check passed

cla/google All necessary CLAs are signed

@munificent munificent deleted the assert-in-initializer branch Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment